cmdstanr icon indicating copy to clipboard operation
cmdstanr copied to clipboard

Add `warmup_draws = T` argument to `read_cmdstan_csv`

Open jsocolar opened this issue 4 years ago • 2 comments

I'd like to change read_cmdstan_csv so that I can avoid reading in warmup draws even if the model was fit with save_warmup = T. Proposed fix is to add a warmup_draws = T argument to read_cmdstan_csv. There would be no change in the default behavior, but if warmup_draws is set to F the returned object would be equivalent to the current default behavior as if the model had been fit with save_warmup = F.

Any comments/objections to me adding this?

jsocolar avatar Oct 05 '21 16:10 jsocolar

I can't think of any problems with this, so yeah fine by me if you want to add this feature. @rok-cesnovar what do you think (and no rush, I know you're dealing with the release stuff)?

jgabry avatar Oct 05 '21 18:10 jgabry

Yeah, seems reasonable to me as well.

rok-cesnovar avatar Oct 05 '21 19:10 rok-cesnovar