cmdstan icon indicating copy to clipboard operation
cmdstan copied to clipboard

2.28 Varmat issue

Open bbbales2 opened this issue 4 years ago • 1 comments

Summary:

This issue is to track what is yet to be done for varmat to go out in 2.27. Edit at will!

This is a resurrected version of the 2.26 Issue: #958

I will try to keep it updated with what I know about:

  • Stanc3 https://github.com/stan-dev/stanc3/pull/755
    • [ ] Create a list of function signatures in Math that support varmat arguments. Work in progress here
    • [x] Figure out a language implementation - A version of the compiler that makes a variable a varmat if the name ends in _varmat is available here
      • [x] Finish the language parts of the design doc. Finished design doc here
      • [x] scalar read/writes of varmat variables might be slow (it's come up when we talk implementation). Results here
  • Math
    • [x] Finish the varmat parts of the design doc. Finished design doc here
    • [ ] Document varmat at the C++ level, from the perspective of someone coming to Math to write a function. This is higher level than Doxygen and lower level than Stan user docs. Work in progress here
    • [x] Update all distributions to work with varmat
      • [x] Non-multivariate distributions. Work in progress here and here
      • [x] Multivariate distributions. Finished here and here
    • [ ] Write varmat implementations for every function that had custom matvar autodiff, work in progress here
    • [x] Write varmat implementations for all the functions used in the constrain functions.
      • [x] Matrix constrains here
      • [x] Upper/lower boundshere

Current Version:

v2.26.0

bbbales2 avatar Feb 03 '21 16:02 bbbales2

Here is the list of fully compatible functions (any signature that could varmat, does varmat, 320 functions): fully_compatible.txt

Here is the list of functions which have at least one signature that doesn't support varmat (197 functions, 44 of which are rngs which won't ever be autodiffed): any_incompatible.txt

bbbales2 avatar Feb 11 '21 13:02 bbbales2