maperture icon indicating copy to clipboard operation
maperture copied to clipboard

Add support for MapTiler SDK

Open petr-hajek opened this issue 1 year ago • 2 comments

Description

As a user of MapTiler SDK & MapTiler maps I'd like an easy way how to compare also MapTiler maps. With this PR I can add MapTiler API key to the config (similar to MapBox). I can also use MapTiler SDK as a renderer (it's almost the same like MapLibre).

I removed the duplicate code in Map.svelte

QA steps

Probably some basic regression of MapLibre & MapBox but should not be affected

Author checklist

Create the PR

  • [x] Fill out PR template
  • [x] Make sure you've added a CHANGELOG entry under "Unreleased"
  • [x] Request a review
  • [ ] Make any requested changes and get approval

After approval

  • [ ] Merge any changes from main into your branch, resolve any conflicts
  • [ ] Squash & merge changes into main
  • [ ] Delete branch

petr-hajek avatar Sep 16 '24 13:09 petr-hajek

@petr-hajek Thanks for this! We'll be taking a look at this soon.

ebrelsford avatar Sep 17 '24 14:09 ebrelsford

It's my first PR into this project and for full transparency, MapTiler is my client so I am open to any feedback. Thanks a lot. Anyway, this is a great tool!

petr-hajek avatar Sep 17 '24 14:09 petr-hajek

Sorry for not responding. I was loaded with other things, but I'll try get back to this soon, thanks for the feedback.

petr-hajek avatar Oct 29 '24 19:10 petr-hajek

Sorry it took me so long.

I moved the url normalization to a separate file and apply it in the GlMap component as well. It now works with Maplibre and Mapbox renderer as well.

petr-hajek avatar Dec 20 '24 13:12 petr-hajek