stackup-bundler icon indicating copy to clipboard operation
stackup-bundler copied to clipboard

Incompatibility between UserOperation struct & PackedUserOperation due to EntryPoint v0.7 changes

Open neavra opened this issue 2 years ago • 0 comments

Changes in the recent UserOperation structure to PackedUserOperation causes transaction to revert in new Accounts. (refer to AA's PR)

One Example would be SimpleAccount.sol, which inherits from BaseAccount: Old version

function validateUserOp(UserOperation calldata userOp, bytes32 userOpHash, uint256 missingAccountFunds)
    external override virtual returns (uint256 validationData) {
        _requireFromEntryPoint();
        validationData = _validateSignature(userOp, userOpHash);
        _validateNonce(userOp.nonce);
        _payPrefund(missingAccountFunds);
    }

New Version

function validateUserOp(
        PackedUserOperation calldata userOp,
        bytes32 userOpHash,
        uint256 missingAccountFunds
    ) external virtual override returns (uint256 validationData) {
        _requireFromEntryPoint();
        validationData = _validateSignature(userOp, userOpHash);
        _validateNonce(userOp.nonce);
        _payPrefund(missingAccountFunds);
    }

I use stackups pkg to obtain the OpHash and Signature for UserOp, which is incompatible with the newer version of validateUserOp, so the transaction would always revert.

Would it be possible to add support for EntryPoint v0.7 changes?

neavra avatar Jan 27 '24 14:01 neavra