stacks-core icon indicating copy to clipboard operation
stacks-core copied to clipboard

implement replace-at

Open pavitthrap opened this issue 3 years ago • 1 comments

Description

This PR implements replace-at. The function takes in a sequence, an index, and an element, and returns a new sequence in which the element is substituted in at the provided index.

Applicable issues

  • fixes #3284

Additional info (benefits, drawbacks, caveats)

The name was modified due to discussion in the issue.

pavitthrap avatar Sep 19 '22 15:09 pavitthrap

Codecov Report

Merging #3296 (1b19aa0) into next (48dc9c9) will decrease coverage by 0.34%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             next    #3296      +/-   ##
==========================================
- Coverage   29.69%   29.35%   -0.35%     
==========================================
  Files         279      278       -1     
  Lines      229610   229613       +3     
==========================================
- Hits        68191    67400     -791     
- Misses     161419   162213     +794     
Impacted Files Coverage Δ
clarity/src/vm/analysis/arithmetic_checker/mod.rs 74.45% <ø> (ø)
...larity/src/vm/analysis/arithmetic_checker/tests.rs 0.00% <0.00%> (ø)
clarity/src/vm/analysis/read_only_checker/mod.rs 76.85% <ø> (ø)
clarity/src/vm/analysis/read_only_checker/tests.rs 0.00% <0.00%> (ø)
...larity/src/vm/analysis/type_checker/natives/mod.rs 56.07% <0.00%> (-0.10%) :arrow_down:
.../src/vm/analysis/type_checker/natives/sequences.rs 59.16% <0.00%> (-3.39%) :arrow_down:
clarity/src/vm/analysis/type_checker/tests/mod.rs 0.00% <0.00%> (ø)
clarity/src/vm/docs/mod.rs 0.00% <0.00%> (ø)
clarity/src/vm/functions/mod.rs 65.21% <0.00%> (-0.14%) :arrow_down:
clarity/src/vm/functions/sequences.rs 49.58% <0.00%> (-5.77%) :arrow_down:
... and 31 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 19 '22 16:09 codecov[bot]

I removed myself from reviewing this PR because @jcnelson is the second reviewer and @kantai has approved.

gregorycoppola avatar Oct 11 '22 21:10 gregorycoppola

The unit tests are breaking because the cost function wasn't implemented. I think this is supposed to go in costs-3.clar?

a3slade avatar Oct 13 '22 23:10 a3slade