stacks-core icon indicating copy to clipboard operation
stacks-core copied to clipboard

Enhance multi-sig ux

Open reedrosenbluth opened this issue 4 years ago • 1 comments

It's currently fairly difficult to sign a multi-sig transaction unless using a single instance of TransactionSigner. This means that the transaction can't easily be signed by multiple parties. This is the case for two reasons:

  1. StacksTransaction::consensus_deserialize() will fail if the transaction is not fully signed. This is problematic if you want to partially sign a transaction, serialize it, and send it to someone else to sign.
  2. The constructor for StacksTransactionSigner sets its sighash field assuming the transaction hasn't already been signed by anyone.

Proposal:

  • add a new deserialize_incomplete() method to StacksTransaction for deserializing partially constructed/signed transactions.
  • upgrade constructor for StacksTransactionSigner such that it reconstructs the sighash from the signatures that already exist.
    • I'm not sure if this is possible...

reedrosenbluth avatar Aug 10 '21 19:08 reedrosenbluth

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 12 '22 01:08 stale[bot]

This issue has been automatically closed. Please reopen if needed.

stale[bot] avatar Oct 01 '22 03:10 stale[bot]

This issue has been automatically closed. Please reopen if needed.

stale[bot] avatar Nov 12 '22 06:11 stale[bot]