sbtc-developer-release icon indicating copy to clipboard operation
sbtc-developer-release copied to clipboard

Integration: broadcast a withdrawal

Open CAGS295 opened this issue 2 years ago • 4 comments

Summary of Changes

Naive test for withdrawals. Follow up on #215 Blocked #350

Testing

Risks

How were these changes tested?

What future testing should occur?

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

CAGS295 avatar Nov 03 '23 06:11 CAGS295

blocked by #350

CAGS295 avatar Nov 03 '23 06:11 CAGS295

Codecov Report

Attention: 101 lines in your changes are missing coverage. Please review.

Comparison is base (6470223) 43.44% compared to head (805cba5) 43.03%. Report is 4 commits behind head on main.

Files Patch % Lines
romeo/src/stacks_client.rs 0.00% 36 Missing :warning:
sbtc-cli/src/commands/withdraw.rs 0.00% 21 Missing :warning:
sbtc-cli/src/main.rs 0.00% 18 Missing :warning:
stacks-core/src/address.rs 0.00% 13 Missing :warning:
sbtc-cli/src/commands/deposit.rs 0.00% 10 Missing :warning:
sbtc-cli/src/commands/broadcast.rs 0.00% 2 Missing :warning:
romeo/src/system.rs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   43.44%   43.03%   -0.41%     
==========================================
  Files          45       45              
  Lines        5467     5519      +52     
  Branches       47       47              
==========================================
  Hits         2375     2375              
- Misses       3091     3143      +52     
  Partials        1        1              
Flag Coverage Δ
unittests 76.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 03 '23 06:11 codecov[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 16 '23 06:11 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 16 '23 06:11 CLAassistant