sbtc-developer-release icon indicating copy to clipboard operation
sbtc-developer-release copied to clipboard

Integration ci

Open CAGS295 opened this issue 2 years ago • 5 comments

Summary of Changes

Follow up PR #215 to add a CI job running integration tests—blocked atm and not actively working on it. I would appreciate feedback on #307 and #215 first.

  1. Devenv's javascript services are too big and are making 'devenv' CI fail. I can't fix it myself right now without digging deeper. I've thought about options: merging javascript containers, increasing runner's resources, having a dedicated devenv profile to skip building unnecessary services, and last but not least, minimizing image size by having a 'release build' for javascript-based services (My first attempt failed).

  2. This PR exports docker image artifacts from the 'devenv build' job. Blocked by 1.

  3. #307 may help with 1. With devenv profiles, I can have a profile with the minimal services needed for testing.

Testing

Risks

How were these changes tested?

What future testing should occur?

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my code
  • [ ] I have commented on my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

CAGS295 avatar Oct 18 '23 22:10 CAGS295

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (c1b5abd) 41.49% compared to head (2cd98d7) 43.09%. Report is 12 commits behind head on main.

Files Patch % Lines
sbtc-cli/src/main.rs 0.00% 11 Missing :warning:
sbtc-cli/src/commands/deposit.rs 0.00% 10 Missing :warning:
sbtc-cli/src/commands/broadcast.rs 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
+ Coverage   41.49%   43.09%   +1.60%     
==========================================
  Files          40       45       +5     
  Lines        5111     5362     +251     
  Branches        0       47      +47     
==========================================
+ Hits         2121     2311     +190     
- Misses       2990     3050      +60     
- Partials        0        1       +1     
Flag Coverage Δ
unittests 76.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 18 '23 22:10 codecov[bot]

What's going on with this PR?

AshtonStephens avatar Oct 25 '23 20:10 AshtonStephens

What's going on with this PR?

@AshtonStephens I added a brief description.

CAGS295 avatar Oct 25 '23 21:10 CAGS295

blocked by #350

CAGS295 avatar Nov 03 '23 05:11 CAGS295

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 16 '23 06:11 CLAassistant