stackrox icon indicating copy to clipboard operation
stackrox copied to clipboard

ROX-29921: Add migration for deployment containers inside of alerts

Open ajheflin opened this issue 3 months ago • 3 comments

Description

PR title sums it up.

Cursor wrote the dummy alerts for the test

User-facing documentation

Testing and quality

  • [ ] the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • [ ] CI results are inspected

Automated testing

  • [ ] added unit tests
  • [ ] added e2e tests
  • [ ] added regression tests
  • [ ] added compatibility tests
  • [ ] modified existing tests

How I validated my change

Unit tests

ajheflin avatar Oct 17 '25 18:10 ajheflin

Images are ready for the commit at 3db9d11.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-247-gd89c6e7e4d.

rhacs-bot avatar Oct 17 '25 19:10 rhacs-bot

Codecov Report

:x: Patch coverage is 89.65517% with 9 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.65%. Comparing base (222dfb9) to head (3db9d11).

Files with missing lines Patch % Lines
...ment_containers_imageidv2/schema/convert_alerts.go 87.50% 4 Missing and 2 partials :warning:
..._deployment_containers_imageidv2/migration_impl.go 90.32% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@                             Coverage Diff                             @@
##           ajheflin/deployment-container-migration   #17358      +/-   ##
===========================================================================
+ Coverage                                    48.63%   48.65%   +0.01%     
===========================================================================
  Files                                         2732     2736       +4     
  Lines                                       203974   204061      +87     
===========================================================================
+ Hits                                         99204    99281      +77     
- Misses                                       97001    97010       +9     
- Partials                                      7769     7770       +1     
Flag Coverage Δ
go-unit-tests 48.65% <89.65%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 17 '25 19:10 codecov[bot]

Wondering if it is worth doing this migration or just change the UI to search the image by FullName and digest , instead of just by digest.

I recommend exploring this option. Seems far simpler than migrating alerts that could potentially be large.

dashrews78 avatar Oct 24 '25 18:10 dashrews78