stackrox icon indicating copy to clipboard operation
stackrox copied to clipboard

fix(CI): Remove pause-reconcile annotation before cleanup

Open mdafsanhossain opened this issue 1 year ago • 9 comments

Description

Setting pause-reconcile annotation to true causes problem when deleting central and secured-cluster services in static clusters(ppc64le) before deploying and running tests. This PR removes the annotation before cleanup of central and secured-cluster is performed.

User-facing documentation

(must be 2 items and both must be checked)

  • [ ] CHANGELOG is updated
  • [ ] CHANGELOG update is not needed
  • [ ] Documentation PR is created and linked above
  • [ ] Documentation is not needed

Testing

  • [ ] inspected CI results

Automated testing

(must be at least 1 item and all items must be checked)

  • [ ] added unit tests
  • [ ] added e2e tests
  • [ ] added regression tests
  • [ ] added compatibility tests
  • [ ] modified existing tests
  • [ ] contributed no automated tests

How I validated my change

Change validated by running the change against an ocp 4.16 ppc64le cluster.

mdafsanhossain avatar Jul 15 '24 10:07 mdafsanhossain

Images are ready for the commit at e085d51.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.x-27-ge085d51227.

rhacs-bot avatar Jul 15 '24 10:07 rhacs-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.12%. Comparing base (e2cffc1) to head (e085d51). Report is 105 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11985      +/-   ##
==========================================
+ Coverage   48.06%   48.12%   +0.05%     
==========================================
  Files        2388     2397       +9     
  Lines      170869   171421     +552     
==========================================
+ Hits        82134    82502     +368     
- Misses      82104    82249     +145     
- Partials     6631     6670      +39     
Flag Coverage Δ
go-unit-tests 48.12% <ø> (+0.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 15 '24 11:07 codecov[bot]

/test powervs-qa-corebpf-e2e-tests /test powervs-4-14-qa-corebpf-e2e-tests

mdafsanhossain avatar Jul 17 '24 12:07 mdafsanhossain

/test powervs-4-14-qa-corebpf-e2e-tests

mdafsanhossain avatar Jul 17 '24 13:07 mdafsanhossain

/test powervs-4-16-qa-corebpf-e2e-tests

mdafsanhossain avatar Jul 23 '24 07:07 mdafsanhossain

/test powervs-4-16-qa-corebpf-e2e-tests

mdafsanhossain avatar Jul 23 '24 13:07 mdafsanhossain

@mdafsanhossain: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-upgrade-tests e085d51227788545f0514e296b9d39ddb36ed207 link false /test gke-upgrade-tests
ci/prow/gke-qa-e2e-tests e085d51227788545f0514e296b9d39ddb36ed207 link false /test gke-qa-e2e-tests
ci/prow/powervs-4-16-qa-corebpf-e2e-tests e085d51227788545f0514e296b9d39ddb36ed207 link false /test powervs-4-16-qa-corebpf-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 23 '24 17:07 openshift-ci[bot]

@robbycochran Can you review this?

mdafsanhossain avatar Jul 24 '24 12:07 mdafsanhossain

@mclasmeier Any thoughts on this PR? You added some related code here: https://github.com/stackrox/stackrox/pull/9866/files. I'm also wondering if the CRs are ever deleted after your change if namespace is not defined?

robbycochran avatar Jul 30 '24 23:07 robbycochran

@robbycochran Are the changes ok or do you suggest any improvements? Or is it good to merge?

mdafsanhossain avatar Aug 07 '24 14:08 mdafsanhossain

This looks good to me.

robbycochran avatar Aug 14 '24 14:08 robbycochran

@robbycochran Can you approve this?

mdafsanhossain avatar Aug 19 '24 13:08 mdafsanhossain