stackrox icon indicating copy to clipboard operation
stackrox copied to clipboard

ROX-21977: compliance profile pagination

Open dashrews78 opened this issue 1 year ago • 2 comments

Description

A detailed explanation of the changes in your PR.

Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.

Checklist

  • [ ] Investigated and inspected CI test results
  • [ ] Unit test and regression tests added
  • [ ] Evaluated and added CHANGELOG entry if required
  • [ ] Determined and documented upgrade steps
  • [ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

Here I tell how I validated my change

TODO(replace-me)
Use this space to explain how you validated that your change functions exactly how you expect it. Feel free to attach JSON snippets, curl commands, screenshots, etc. Apply a simple benchmark: would the information you provided convince any reviewer or any external reader that you did enough to validate your change.

It is acceptable to assume trust and keep this section light, e.g. as a bullet-point list.

It is acceptable to skip testing in cases when CI is sufficient, or it's a markdown or code comment change only.
It is also acceptable to skip testing for changes that are too taxing to test before merging. In such case you are responsible for the change after it gets merged which includes reverting, fixing, etc. Make sure you validate the change ASAP after it gets merged or explain in PR when the validation will be performed.
Explain here why you skipped testing in case you did so.

Have you created automated tests for your change? Explain here which validation activities you did manually and why so.

Reminder for reviewers

In addition to reviewing code here, reviewers must also review testing and request further testing in case the performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the performed testing and you are satisfied with it.

dashrews78 avatar May 09 '24 14:05 dashrews78

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar May 09 '24 14:05 openshift-ci[bot]

Images are ready for the commit at edd48f5.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-712-gedd48f5bcc.

rhacs-bot avatar May 09 '24 15:05 rhacs-bot

Codecov Report

Attention: Patch coverage is 81.33333% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 47.93%. Comparing base (a1d15ac) to head (edd48f5). Report is 290 commits behind head on master.

Files Patch % Lines
...lianceoperator/v2/profiles/service/service_impl.go 70.90% 11 Missing and 5 partials :warning:
...ceoperator/v2/profiles/datastore/datastore_impl.go 86.36% 8 Missing and 4 partials :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #11052       +/-   ##
===========================================
- Coverage   48.58%   47.93%    -0.66%     
===========================================
  Files         641     2330     +1689     
  Lines       63975   166632   +102657     
===========================================
+ Hits        31085    79869    +48784     
- Misses      30093    80426    +50333     
- Partials     2797     6337     +3540     
Flag Coverage Δ
go-unit-tests 47.93% <81.33%> (-0.66%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 21 '24 17:05 codecov[bot]