stackrox icon indicating copy to clipboard operation
stackrox copied to clipboard

ROX-23591: Improve Manual CVE Update Process

Open daynewlee opened this issue 1 year ago • 2 comments

Description

A detailed explanation of the changes in your PR.

Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.

Checklist

  • [ ] Investigated and inspected CI test results
  • [ ] Unit test and regression tests added
  • [ ] Evaluated and added CHANGELOG entry if required
  • [ ] Determined and documented upgrade steps
  • [ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

Here I tell how I validated my change

TODO(replace-me)
Use this space to explain how you validated that your change functions exactly how you expect it. Feel free to attach JSON snippets, curl commands, screenshots, etc. Apply a simple benchmark: would the information you provided convince any reviewer or any external reader that you did enough to validate your change.

It is acceptable to assume trust and keep this section light, e.g. as a bullet-point list.

It is acceptable to skip testing in cases when CI is sufficient, or it's a markdown or code comment change only.
It is also acceptable to skip testing for changes that are too taxing to test before merging. In such case you are responsible for the change after it gets merged which includes reverting, fixing, etc. Make sure you validate the change ASAP after it gets merged or explain in PR when the validation will be performed.
Explain here why you skipped testing in case you did so.

Have you created automated tests for your change? Explain here which validation activities you did manually and why so.

Reminder for reviewers

In addition to reviewing code here, reviewers must also review testing and request further testing in case the performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the performed testing and you are satisfied with it.

daynewlee avatar May 08 '24 19:05 daynewlee

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar May 08 '24 19:05 openshift-ci[bot]

Images are ready for the commit at a035925.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-1121-ga0359259be.

rhacs-bot avatar May 08 '24 20:05 rhacs-bot

@daynewlee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-qa-e2e-tests 93e5a5491b3d4e32068743677a3a2982ab294b81 link false /test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 14 '24 17:05 openshift-ci[bot]

The manual updater was successfully ran in the updaters CI workflow. Not sure if it's enough for the testing. Please let me know.

daynewlee avatar May 14 '24 21:05 daynewlee

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.96%. Comparing base (29a024f) to head (d7db958). Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11045      +/-   ##
==========================================
- Coverage   47.97%   47.96%   -0.01%     
==========================================
  Files        2330     2330              
  Lines      166706   166706              
==========================================
- Hits        79976    79967       -9     
- Misses      80375    80386      +11     
+ Partials     6355     6353       -2     
Flag Coverage Δ
go-unit-tests 47.96% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 22 '24 17:05 codecov[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.05%. Comparing base (98227dd) to head (a035925).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11045      +/-   ##
==========================================
- Coverage   48.05%   48.05%   -0.01%     
==========================================
  Files        2373     2373              
  Lines      169971   169971              
==========================================
- Hits        81679    81677       -2     
- Misses      81726    81727       +1     
- Partials     6566     6567       +1     
Flag Coverage Δ
go-unit-tests 48.05% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 23 '24 19:05 codecov-commenter

@daynewlee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-candidate-scanner-v4-tests 472854aa79539cd490c7e0ac5a7a44cfad438ac6 link false /test ocp-4-candidate-scanner-v4-tests
ci/prow/ocp-4-12-nongroovy-e2e-tests a0359259bea14ad7161ed35272a1e201ea8b578a link false /test ocp-4-12-nongroovy-e2e-tests
ci/prow/ocp-4-12-scanner-v4-tests a0359259bea14ad7161ed35272a1e201ea8b578a link false /test ocp-4-12-scanner-v4-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jun 26 '24 05:06 openshift-ci[bot]