scanner icon indicating copy to clipboard operation
scanner copied to clipboard

ROX-22019: Protobuf v2 migration

Open mtodor opened this issue 1 year ago • 1 comments

This PR migrates scanner from gogo protobuf V1 to protobuf V2 stack.

To simplify the review, diffs can checked per commit.

Commit Change proto gen tools to protobuf V2:

  • changes proto generation tools to V2 tools
  • split generated .pb.go file into multiple files:
    • .pb.go - contains structs
    • *_vtproto.pb.go - contains vtproto generated code. Primarily marshaling/unmarshalling, etc.
    • *_grpc.pb.go - contains gRCP bindings code
  • added 3rd party proto files. They have been part of github.com/grpc-ecosystem/grpc-gateway before, but they are not included anymore.

Commit Generate code from proto files:

  • contains only generated code

Commit Adjust code for protobuf V2 generated code:

  • change to gRPC Gateway V2
  • replace old gogo proto types with the protobuf V2 ones

Note The pined version of stackrox will be changed before merging. But that will require changes on PR in stackrox first.

mtodor avatar May 08 '24 17:05 mtodor