collector icon indicating copy to clipboard operation
collector copied to clipboard

POC for using stackrox/storage/ResourceCollection

Open robbycochran opened this issue 1 year ago • 2 comments

Description

Example for using a ResourceCollection storage object as namespace filter for runtime config. Updated stackrox proto to 4.4 to get latest version of the ResourceCollection proto, which also required including transitive dependencies.

Checklist

  • [ ] Investigated and inspected CI test results
  • [ ] Updated documentation accordingly

Automated testing

  • [ ] Added unit tests
  • [ ] Added integration tests
  • [ ] Added regression tests

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me) Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes") In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.

For more details, ref the Confluence page about this section.

robbycochran avatar Mar 28 '24 19:03 robbycochran

Looks like a good start. Thanks for doing this. Instead of doing a traditional PR review I have decided to build on your PR. My PR is here https://github.com/stackrox/collector/pull/1622

Improvements include use of the AND operator, checking cluster level rules, refactoring to reduce nesting, and more unit tests.

JoukoVirtanen avatar Mar 29 '24 18:03 JoukoVirtanen

Looks like a good start. Thanks for doing this. Instead of doing a traditional PR review I have decided to build on your PR. My PR is here #1622

Improvements include use of the AND operator, checking cluster level rules, refactoring to reduce nesting, and more unit tests.

I also added the ability to check if there is a match in the embedded collections.

JoukoVirtanen avatar Mar 30 '24 00:03 JoukoVirtanen