Sishir Giri
Sishir Giri
> Have a few changes, one in particular that is a must. Please lmk if you have any questions! > > As a side note kind of unrelated to this...
> Left second round of reviews, overall looking good, I think we just need test cases for the community pool funding for val set creation fee Thank you @mattverse for...
Ready for Review @mattverse 🌮 [`224bbd9`](https://github.com/osmosis-labs/osmosis/pull/2892/commits/224bbd96ab45338cb4138b5ce7ecc5db6e222dfc) Ended up resorting to your suggested idea
Thank you @mattverse for feedback. Resolved all of it [`3883537`](https://github.com/osmosis-labs/osmosis/commit/3883537a9b8d130f674dd86a5f60aaeb4c62940c)
Thank you @alexanderbez for your feedback! implemented all of it here [`c64682a`](https://github.com/osmosis-labs/osmosis/pull/2892/commits/c64682a0aae4a43771f50db2b9738bbb365b73f0)
> LGTM! Did we decide to limit the number of validators one can split delegate to? I dont have any preference for or against, I just remember this being talked...
Thank you @alexanderbez resolved all your comments here [`a3a55cc`](https://github.com/osmosis-labs/osmosis/pull/2892/commits/a3a55cc2d18793d3e4dfaea01ee2e7881951c929)
@dancoombs i started working on this. Currently, the plan is to split FeeEstimator struct into `BundleFeeEstimator` and `UOFeeEstimator`. Please lmk if there is any specific details about this issue you...
Closing this as we donot need fees to create valset