stgit icon indicating copy to clipboard operation
stgit copied to clipboard

stgit.el update

Open nicolas-graves opened this issue 1 year ago • 7 comments

Hi StGit!

I was trying to package stgit.el for Guix, and I noticed tere is quite some cleaning to do on stgit.el, I have the following warnings on compilation: log.txt

I also wondered about the status of the package, I've seen that magit-stgit has been updated and I'm wondering if the statement

If you are looking for full fledged StGit support in Emacs, then have a look at `stgit.el' which is distributed with StGit.

as found on MELPA stable still holds true, or if magit-stgit is the one recommended now (maybe we should make a release for MELPA stable ?).

nicolas-graves avatar Jan 06 '25 12:01 nicolas-graves

Hi @nicolas-graves. Thanks for working on packaging StGit for Guix.

The state of StGit's various emacs packages is not great.

You're right that magit-stgit has had some recent-ish maintenance and may be in better shape than stgit.el. But I can't personally vouch for whether magit-stgit is in a release-worthy state. Perhaps @tohojo could comment?

jpgrayson avatar Jan 06 '25 15:01 jpgrayson

Well, I'm using it for my daily(ish) work, so while the bindings are not complete, I'd say it's definitely a usable subset.

I've never used stgit,el, so can't really say anything about how that compares to magit-stgit, though :)

tohojo avatar Jan 06 '25 15:01 tohojo

Thanks for that perspective, @tohojo--that's helpful. So perhaps it would make sense to tag the latest magit-stgit as @nicolas-graves suggests?

Do we think that would be a 2.2.0 or 3.0.0 tag?

I'm not super familiar with how MELPA works, but it appears from looking at the melpa recipe for StGit that if we were to push a new magit-stgit tag, MELPA would just use that tag automatically.

jpgrayson avatar Jan 06 '25 15:01 jpgrayson

Yeah, I agree that tagging a new version makes sense. No strong opinion about which version number to go with. I suppose the switch to transient could be occasion enough to go for the big 3.0? :)

No idea how melpa works, but from just looking at that recipe I guess you're right?

tohojo avatar Jan 06 '25 15:01 tohojo

I'll create a new 3.0.0 tag for magit-stgit.

jpgrayson avatar Jan 06 '25 15:01 jpgrayson

I tried using stgit.el today and immediatley ran into symbol void: git-status, which i guess comes from the venerable git.el from git/contrib/emacs (well, used to to come from up until several years ago)

Reasonable-Solutions avatar Feb 24 '25 11:02 Reasonable-Solutions

I believe this issue is proposing we release a version bump of stgit.el. I've recently done some work on it that fixes a number of warnings so I think a version bump would be warranted.

However, we should close any open issues before doing that. I read all of the issue titles and arrived at this list.

Blocking issues: #560

MorganJamesSmith avatar Apr 25 '25 18:04 MorganJamesSmith