octohat icon indicating copy to clipboard operation
octohat copied to clipboard

Add support to Docker

Open jivagoalves opened this issue 11 years ago • 3 comments

jivagoalves avatar Feb 20 '15 10:02 jivagoalves

Can you guys help me out with the build failure? I'm confused. Am I supposed to set GITHUB_TOKEN somewhere to make specs pass on CI?

jivagoalves avatar Feb 20 '15 13:02 jivagoalves

@jivagoalves indeed you need to set up 5 environment vars to run the tests, but on the travis file you will see them as env: global and each var after secure... i'm not sure why it's not reading the travis file when using docker containers https://travis-ci.org/stackbuilders/octohat/jobs/51400229 you can see "Setting environment variables from .travis.yml" but is not on the build from this PR... i guess there must be something special between docker containers and env vars set on the travis file

juanpaucar avatar Feb 20 '15 14:02 juanpaucar

@juanpaucar thanks for your help! I understand we need to set the env vars locally in order to run the specs. However, I believe travis will do that for us in the build as you said. I don't think travis is running any docker container because they are using ubuntu as worker while the docker image I'm using is based from debian. I'll take another look later when I get a chance. Thanks!

jivagoalves avatar Feb 20 '15 15:02 jivagoalves