stack icon indicating copy to clipboard operation
stack copied to clipboard

Now users can submit forms by hitting enter

Open mainak9163 opened this issue 1 year ago • 1 comments

mainak9163 avatar May 25 '24 14:05 mainak9163

@mainakkaniam is attempting to deploy a commit to the Stackframe Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 25 '24 14:05 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 26 '24 09:05 CLAassistant

Since this will capture all Enter presses on the page, this will cause weird behaviour if there are other things on the same page as the SignIn component. I believe the better way to do this is to have an <input type="submit" hidden> inside of a <form /> element, so we can use the default browser behavior. This should probably also be done on all the forms in stack-server.

@fomalhautb I believe you already built something like this? Can you combine it with this PR?

N2D4 avatar May 28 '24 08:05 N2D4

Okay!

mainak9163 avatar May 28 '24 08:05 mainak9163

Moving to #57

fomalhautb avatar May 28 '24 13:05 fomalhautb