stack icon indicating copy to clipboard operation
stack copied to clipboard

Support bold in the email text markdown editor

Open fomalhautb opened this issue 1 year ago • 2 comments

Similar to how the link works in the email editor

fomalhautb avatar Oct 10 '24 18:10 fomalhautb

Hello @fomalhautb. Can you explain the issue in more detail? I would like to work on this.

raj17ce avatar Oct 11 '24 06:10 raj17ce

Hey @fomalhautb

I tried to look into this issue but I think bold is already supported in every email template. Please give more info or image for better clarification.

I would like to work on this.

Jarvis-3000 avatar Oct 11 '24 08:10 Jarvis-3000

https://github.com/stack-auth/stack/blob/efaf6db3f713f069b7dc021a6638d102ca616aa4/packages/stack-emails/src/editor/blocks/block-text.tsx#L101

This is for example how we handle hyperlinks, we need to do the same for bold text. Please consider the scenario where hyperlinks and bold text are nested or have overlaps.

fomalhautb avatar Oct 16 '24 17:10 fomalhautb

Hey @fomalhautb , I tried looking up on the email templates in the editor. it seems that there's already support for setting the font weight to bold. Here's an attached screenshot. image

Let me know how should I proceed, because the issue seems to be already solved.

raj17ce avatar Oct 17 '24 06:10 raj17ce

Hey @fomalhautb , I tried looking up on the email templates in the editor. it seems that there's already support for setting the font weight to bold. Here's an attached screenshot. image

Let me know how should I proceed, because the issue seems to be already solved.

Oh by bold text I mean bold a substring, like this is a bold substring.

fomalhautb avatar Oct 17 '24 23:10 fomalhautb

Basically it should be format like:

**this is some bold** this is some normal text, right?

suryavirkapur avatar Oct 19 '24 08:10 suryavirkapur

Basically it should be format like:

**this is some bold** this is some normal text, right?

yes

fomalhautb avatar Oct 19 '24 18:10 fomalhautb

Hi @fomalhautb, I would like to work on this issue, pl assign it to me.

sriharika13 avatar Oct 21 '24 08:10 sriharika13

@fomalhautb i have raised the PR could you please suggest if there are any changes required

Mubashirshariq avatar Oct 23 '24 05:10 Mubashirshariq