Bug: Improper Handling of Request Body Parameters in User and Team Creation APIs
I have identified a few issues with the server APIs. Some APIs are accepting data in the request body that is not being used in the route handlers.
Issues with following APIs
1. Create User
-
Issue: When creating a new user, the API accepts
selected_team_id, but the route handler does not make use ofselected_team_id. -
2. Create a Team
-
Issue: When creating a new team, the API accepts
profile_image_url, but the route handler does not add theprofile_image_urlto the newly created team. -
Probable Solutions
1. Create User
-
Solution 1: Do not accept
selected_team_idat all, as it does not make sense to ask for a team ID when the membership does not exist. -
Solution 2: Create the membership between the newly created user and
selected_team_id, then make the team the selected team.
2. Create a Team
-
Solution: Pass
profile_image_urlwhile creating the new team.
Additional Notes:
I would love to work on this issue. Please assign it to me if possible.
Sorry somehow missed this issue, you can work on it if you are still interested
Yes. I am interested. Thank you.
You can join our discord and ask me directly if you have any question or need any help
I have already joined the discord. I will reach out if I need anything help.
@fomalhautb if @kfahad5607 is not working on it, i can work on this
Hi @dev13-suthar. Sorry to keep this fix hanging. I was busy at work but I will be creating a PR for it.