stac-fastapi icon indicating copy to clipboard operation
stac-fastapi copied to clipboard

Allowing to fix the request base URL via an env var

Open constantinius opened this issue 2 years ago • 1 comments

Related Issue(s):

  • #581

Description:

A new env var REQUEST_BASE_URL is introduced to fix the base URL to the supplied value. When this variable is not set, the usual way of determining the base URL is used.

PR Checklist:

  • [x] pre-commit hooks pass locally
  • [x] Tests pass (run make test)
  • [ ] Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • [ ] Changes are added to the CHANGELOG.

constantinius avatar Jun 21 '23 22:06 constantinius

As for https://github.com/stac-utils/stac-fastapi/pull/636, I'm not convince we need this.

If the baseurl is not properly returned by starlette it usually mean there is a configuration issue in the proxy 🤔

vincentsarago avatar Apr 09 '24 18:04 vincentsarago

Should we close this for now?

jonhealy1 avatar Jun 20 '24 15:06 jonhealy1

@jonhealy1 IMO yes

vincentsarago avatar Jun 21 '24 07:06 vincentsarago

closing ..... feel free to reopen

jonhealy1 avatar Jun 21 '24 10:06 jonhealy1