stac-fastapi
stac-fastapi copied to clipboard
Allowing to fix the request base URL via an env var
Related Issue(s):
- #581
Description:
A new env var REQUEST_BASE_URL is introduced to fix the base URL to the supplied value. When this variable is not set, the usual way of determining the base URL is used.
PR Checklist:
- [x]
pre-commithooks pass locally - [x] Tests pass (run
make test) - [ ] Documentation has been updated to reflect changes, if applicable, and docs build successfully (run
make docs) - [ ] Changes are added to the CHANGELOG.
As for https://github.com/stac-utils/stac-fastapi/pull/636, I'm not convince we need this.
If the baseurl is not properly returned by starlette it usually mean there is a configuration issue in the proxy 🤔
Should we close this for now?
@jonhealy1 IMO yes
closing ..... feel free to reopen