phpstan-dba icon indicating copy to clipboard operation
phpstan-dba copied to clipboard

Support table aliases in PdoQueryReflector

Open staabm opened this issue 4 years ago • 3 comments

Atm table aliases only work with the MysqliQueryReflector

see grafik

grafik

staabm avatar Feb 11 '22 12:02 staabm

@staabm Hey, I was thinking I would explore some options regarding this issue, but I'm not sure what's the status of implementing some base of an sql parser - I've checked some comments in https://github.com/staabm/phpstan-dba/pull/313 and I'm not sure if I should wait for some base implementation or to go ahead with this using phpmyadmin sql parser or just go ahead with something else? wdyt?

thx

p4veI avatar Aug 18 '22 16:08 p4veI

Hey.

I am not having concrete plans yet.

I would agree with anything which is not huge and works the same way on mysql/mysqli/pgsql without ugly hacks, while implementing features not possible right now

staabm avatar Aug 18 '22 16:08 staabm

you may consider using https://github.com/SQLFTW/sqlftw as a parser

staabm avatar Aug 26 '22 10:08 staabm

@p4veI in https://github.com/staabm/phpstan-dba/pull/505 landed the initial implementation/integration of a sql parser

staabm avatar Feb 17 '23 10:02 staabm