ssolson
ssolson
> ` PacWave_resource_characterization_example.ipynb - Folium map error` > > This is not an MHKiT error > > You just need to pip install folium > > folium is only used...
I take responsibility for not catching this but I did not realize that the wave module xarray conversion made the functions so slow they are now unusable. E.g. in the...
> @ssolson thanks for addressing the cdip and D3D examples in [akeeste#4](https://github.com/akeeste/MHKiT-Python/pull/4). > > I was also able to get the directional_waves example to run when the cached was cleared....
> @ssolson Okay understood. Seems odd as the methodology is essentially the same now, but applied on an xarray dataset (and with type handling). I wonder if the delay is...
@akeeste can you merge the fixes in https://github.com/akeeste/MHKiT-Python/pull/5?
> If I can jump in, a part of this problem might be because yall are using Datasets for single variables rather than DataArrays. This line `fp = S.idxmax(dim=frequency_dimension)` will...
Still working in a standalone environment. I have converted the above into a functional approach compatible with MHKiT and works with our current Tanana river example. I still need to...
Close #375
@jmcvey3 with your last push you are fixing numpy 2.0 issues. Could you help me out by addressing the remaining failing tests in PR #333? The Dolfyn tests seem to...
Please do not merge this until after we get #307 into master.