Autodiff-Puzzles
Autodiff-Puzzles copied to clipboard
Problem 15 1D Convolution: Fix convolution inconsistencies
There are two problems with the convolution definition in problem 15
-
jindex should run from 0 to K-1. I have corrected this. - The function
fcallsnp.convolvewhich flips y before applying the convolution. So the function behavior is inconsistent with indexing in the convolution definition. Can either change the definition or changefto usenp.correlatewhich does not flip. I have done the latter as I think not flipping is the standard in deep learning.