gradle-node-plugin icon indicating copy to clipboard operation
gradle-node-plugin copied to clipboard

Rename NodeExtension.nodeModulesDir to workDir

Open srs opened this issue 9 years ago • 1 comments

Rename NodeExtension.nodeModulesDir to workDir. This makes it consistent with other tasks which call the same concept a "working directory".

srs avatar Jun 27 '16 19:06 srs

I really second this one. Naively setting nodeModulesDir to 'build/node_modules' doesn't do the job; why became apparent after digging through the sources.

I would however grasped 'workingDir' instantly, and also the fact that 'package.json' is required to be there in order for npmInstall to actually download the modules.

kash74 avatar Jul 12 '16 13:07 kash74