live_toast icon indicating copy to clipboard operation
live_toast copied to clipboard

feat: add i18n support for default error messages

Open elephantoss opened this issue 1 year ago • 8 comments

@srcrip I test locally with a project of mine and it works as expected.

Please let me know if you don't like the direction of the solution and I can try to explore other ideas.

closes #13

elephantoss avatar Jul 04 '24 12:07 elephantoss

That is some really great looking work so far. I'm glad you opened this cause I don't use gettext much. Just assign me for review whenever you're ready for me to formally review. Only request I have is that it would be nice if we could have some tests around this.

srcrip avatar Jul 09 '24 17:07 srcrip

@srcrip I'll add tests in the demo folder and I ping you when it is done

elephantoss avatar Jul 09 '24 19:07 elephantoss

@srcrip I added the test but I don't have permission to assign you as a reviewer.

elephantoss avatar Jul 09 '24 21:07 elephantoss

Wonderful! I'll take a look.

srcrip avatar Jul 10 '24 17:07 srcrip

@srcrip do you have any idea when you'll be able to review this PR?

elephantoss avatar Jul 16 '24 15:07 elephantoss

@srcrip I think I've found a way to simplify this PR a little bit. I'll play around a bit and try to push a new version in the next couple of days

elephantoss avatar Jul 24 '24 20:07 elephantoss

@srcrip just pushed a new version that is less intrusive and more straightforward to use.

elephantoss avatar Jul 25 '24 11:07 elephantoss

@srcrip, I'd appreciate some feedback on this PR. Specially if there is anything preventing you from merging it.

Thanks in advance

elephantoss avatar Aug 09 '24 12:08 elephantoss

Thank you! Sorry for the delay, I've been working on a different feature that's taken up a lot of my time for the project.

srcrip avatar Oct 07 '24 20:10 srcrip