sourced-ce icon indicating copy to clipboard operation
sourced-ce copied to clipboard

Avoid repeating hard-coded values for different containers

Open smacker opened this issue 6 years ago • 2 comments

One of the solutions might be to use env vars. Related discussion: https://github.com/src-d/sourced-ce/pull/54#discussion_r294690184

smacker avatar Jun 19 '19 16:06 smacker

This is old, I think this has been fixed using anchors.

se7entyse7en avatar Oct 24 '19 14:10 se7entyse7en

Nope. The requirement was about to use named env vars to signify the constraints between the same data in different containers,

e.g. to use ${METADATA_DB_NAME-metadata} instead of the same hardcoded metadata in:

keys in
x-superset-env.METADATA_DB docker-compose.yml#L22
ghsync.GHSYNC_POSTGRES_DB docker-compose.yml#L74
metadatadb.POSTGRES_DB docker-compose.yml#L139

dpordomingo avatar Oct 28 '19 16:10 dpordomingo