go-siva icon indicating copy to clipboard operation
go-siva copied to clipboard
verified publisher icon src-d

clarification on spec regarding CRC

Open jcftang opened this issue 7 years ago • 3 comments

I'm trying to implement this format in python

could you clarify this - https://github.com/src-d/go-siva/blame/master/SPEC.md#L68

Is it the crc32 of each element concatenated into a string that get's crc'd or is it one crc that you are updating? Also what is 'Entries' ? is it the crc of each index entry or the crc of a list of entries The spec isn't entirely clear to me on what it's meant to be.

jcftang avatar Jun 23 '18 20:06 jcftang

I also played around with that. It's the CRC of the blue part in the png of the readme.md.

And when you get to the other CRC for each file, it's always zero in all the siva files I've seen so far...

hmycroft avatar Jul 06 '18 13:07 hmycroft

I eventually figured it out and have a my test python version writing out blocks that the go implementation can read.

jcftang avatar Jul 06 '18 14:07 jcftang

There was an error generating CRC that made them always 0, see #45, is fixed in #46.

Entries is the bytes from all entries in that index.

jfontan avatar Jun 13 '19 07:06 jfontan