enry icon indicating copy to clipboard operation
enry copied to clipboard

Gitattributes

Open dpaz opened this issue 8 years ago • 9 comments

Added support for .gitattributes which works similar to github/linguist #18

dpaz avatar Jun 23 '17 08:06 dpaz

@dpaz You should add tests for new functionality

mcarmonaa avatar Jun 26 '17 06:06 mcarmonaa

Codecov Report

Merging #50 into master will decrease coverage by 0.97%. The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   84.78%   83.81%   -0.98%     
==========================================
  Files          16       16              
  Lines         940     1044     +104     
==========================================
+ Hits          797      875      +78     
- Misses         84      103      +19     
- Partials       59       66       +7
Impacted Files Coverage Δ
common.go 90.73% <100%> (+0.37%) :arrow_up:
utils.go 71.3% <72.91%> (+8.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9de4d35...0a267e9. Read the comment docs.

codecov[bot] avatar Jun 27 '17 09:06 codecov[bot]

Codecov Report

Merging #50 into master will decrease coverage by <.01%. The diff coverage is 80.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   85.03%   85.02%   -0.01%     
==========================================
  Files          16       17       +1     
  Lines         942     1062     +120     
==========================================
+ Hits          801      903     +102     
- Misses         83       99      +16     
- Partials       58       60       +2
Impacted Files Coverage Δ
common.go 85.3% <0%> (-5.15%) :arrow_down:
gitattributes.go 89.81% <89.81%> (ø)
utils.go 100% <0%> (+26.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 200c153...11ef5ed. Read the comment docs.

codecov-io avatar Jul 04 '17 09:07 codecov-io

@dpaz Apart from the review changes, please rebase.

abeaumont avatar Jul 11 '17 08:07 abeaumont

@mcarmonaa can you validate if everything is ok from your side?

abeaumont avatar Jul 18 '17 10:07 abeaumont

As linguist's README says: Add a .gitattributes file to your project and use standard git-style path matchers for the files you want to override..., If we have a different way to specify a path and don't support the same style that linguist uses, we won't be compatible.

The same .gitattributes file should work with linguist and enry.

mcarmonaa avatar Jul 19 '17 06:07 mcarmonaa

Like @mcarmonaa is saying, I don't really know If go regexps are a superset of git path matchers, If they are this will be fully compatible, if not we need to add some intermediate regexp motor, a converter or something.

dpaz avatar Jul 19 '17 08:07 dpaz

@dpaz how does linguist implement those regexps?

abeaumont avatar Jul 19 '17 10:07 abeaumont

We need a hero to finish this!

hero

vmarkovtsev avatar Jan 31 '18 09:01 vmarkovtsev