Improve UX on Experiment Manager

[dpordomingo]

I'll summarize here the UX problems that I spotted at https://github.com/src-d/code-annotation/pull/195#pullrequestreview-103892878

They're based on my personal opinions, so they should be validated or discarded by @ricardobaeta

The current behavior is:

1. user clicks on "create new" button
2. user defines name/description, but the user can not upload a DB → the user must press create
3. the modal is automatically reopened without giving any special feedback to the user, the upload DB selector is now usable
4. the user selects a DB file → it is automatically uploaded without waiting the user press save
5. every time the user press save, the modal es reopened automatically.

If the logic in behind is maintained, I'd suggest:

• If when a new experiment is being created, the database selector cannot be used, it should be removed from the modal,
• After creating a new experiment, I wouldn't open the modal automatically without providing feedback to the user; it should be manually opened by the user, or it should be provided some feedback,
• When the user selects a new DB file, it should not be pushed/added until the user press save because it is the expected behavior
• The save button should not open the same modal again without clear feedback:
  • if the update succeeds, it should be said so, and the modal should be closed
  • if the update fails, it should be shown an error
    (There is an example of this problem at https://github.com/src-d/code-annotation/issues/220)

[ricardobaeta]

Hi @dpordomingo :) Thank you very much for the time you put into this!

I couldn't agree more. When I saw the animated gif @carlosms attached to the PR I thought it was a temporary issue, not the final experience. My bad I didn't raise the issue right on. As you said, and as it was propotyped, the flow/ui behaviour on the edit or create should be linear, and not interrupted by a closing/opening modal. If you click the create button, without uploading a DB, the survey will be created without the DB. The user has to edit the recently created survey in order to upload DB. Same for edit when you click save. The modal should stay open until the user clicks the primary action button, either it's save or create for both user scenarios.

side-note: I'm using survey still, instead of experiment because the rational brought upon by Marcelo. I'm sure when he has the time he will jump on board and clarify this semantics issue, we already talked about. Pinging @marnovo , for him to get all of us in the same page.