code-annotation Default env variables mix binding IP addr with public URL

If the default env variables are used, then: CAT_HOST = 0.0.0.0 CAT_PORT = 8080 CAT_SERVER_URL = <CAT_HOST>:<CAT_PORT> CAT_UI_DOMAIN = <CAT_HOST>:<CAT_PORT>

With these default values, after a login the browser will try to access 0.0.0.0:8080, and fail.

Feb 26 '18 16:02 carlosms

I think it no longer happens since https://github.com/src-d/code-annotation/pull/142 Feel free to reopen if I missed something

Mar 09 '18 16:03 dpordomingo

I doesn't happen for login, but I think the problem is still the same for any other API call, isn't it? The clients will try to access 0.0.0.0:8080.

Mar 14 '18 11:03 carlosms

Could you help understand how often does this happen and who is affected by this?

Apr 10 '18 12:04 bzz

This would only affect an installation where you leave the env. variables unset. For our deployment this is not a problem since we set the env. variables, and this would probably be the expected case in most installations.

Apr 10 '18 12:04 carlosms

It affects in development. I have a fix for it in a branch to improve dev experience, that I'll resume once we start working on CAT again :)

Apr 10 '18 23:04 dpordomingo