sneaker icon indicating copy to clipboard operation
sneaker copied to clipboard

Laravel 8/9

Open bryanrscott opened this issue 5 years ago • 16 comments

Suggested updates for laravel 8. I am suggesting a new branch as laravel 8 upgrades to symphony 5. Includes edits by @npostman Welcome any additional suggestions.

bryanrscott avatar Sep 14 '20 00:09 bryanrscott

Not yet ready

bryanrscott avatar Sep 14 '20 00:09 bryanrscott

Confirmed functional. Misread configuration

bryanrscott avatar Sep 14 '20 00:09 bryanrscott

Implemented and confirmed to work with L8.6.0. Thanks @bryanrscott

npostman avatar Sep 29 '20 08:09 npostman

Acknowledgement link for @npostman https://github.com/squareboat/sneaker/pull/57

bryanrscott avatar Oct 08 '20 00:10 bryanrscott

Up and running in Laravel 8. Thanks @bryanrscott

ahosker avatar Oct 09 '20 14:10 ahosker

@JorisDebonnet Agree and have updated README as suggested

bryanrscott avatar Oct 29 '20 20:10 bryanrscott

@JorisDebonnet Agree and have updated README as suggested

Okay, uh, but it's not 100% as I meant now 😄 My suggestion for the 'mathematically most correct' version was this:

#### For Laravel <= 5.2, please use the [v1 branch](https://github.com/squareboat/sneaker/tree/v1)!
#### For Laravel 5.3 <= version <= 6.x, please use the [v5 branch](https://github.com/squareboat/sneaker/tree/v5)!
#### For Laravel 7.0 <= version <= 8.x, please use the [v7 branch](https://github.com/squareboat/sneaker/tree/v7)!

Alternatively, 'plain English' could be even easier to read:

#### For Laravel up to 5.2, please use the [v1 branch](https://github.com/squareboat/sneaker/tree/v1)!
#### For Laravel 5.3 to 6.x, please use the [v5 branch](https://github.com/squareboat/sneaker/tree/v5)!
#### For Laravel 7 and up, please use the [v7 branch](https://github.com/squareboat/sneaker/tree/v7)!

Or did I misunderstand, and does Laravel 7 require a separate branch from Laravel 8+? Then I guess the last line would need to say "for Laravel 7.x, please use ..."

JorisDebonnet avatar Nov 16 '20 10:11 JorisDebonnet

Yes Laravel 8 would need a seperate branch.

bryanrscott avatar Nov 16 '20 12:11 bryanrscott

Hopefully Laravel support for version 8 can be added soon.

jvandervalk avatar Feb 02 '21 10:02 jvandervalk

Hopefully Laravel support for version 8 can be added soon.

For what it's worth, here's how to use bryanrscott's fork in your own project (that's what I'm doing at the moment) in order to use Sneaker with Laravel 8:

composer.json

{
    "require": {
        "squareboat/sneaker": "dev-master"
    },
    "repositories": [ { "type": "vcs", "url": "https://github.com/bryanrscott/sneaker" } ],
}

JorisDebonnet avatar Apr 05 '21 20:04 JorisDebonnet

Hi, I just ported my application to Laravel 8 and Sneaker does not seem to work. I have run into this same issue when porting to Laravel 6 and 7, and it was due to the composer version (I had to downgrade composer to 1.10). But now this happens both with composer 1 and 2.

This is the message at the end of composer install:

Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover

In Container.php line 835:
                                          
  Target class [sneaker] does not exist.  
                                          

In Container.php line 833:
                                
  Class sneaker does not exist  

Do ypu have a workaround for this?

michaelheumann avatar May 14 '21 00:05 michaelheumann

@michaelheumann I would recommend a) use composer 2 b) uninstall sneaker, including commenting out the lines in app/Exceptions/Handler.php c) composer update d) install sneaker via composer e) complete install by uncommenting lines in app/Exceptions/Handler.php

bryanrscott avatar May 14 '21 01:05 bryanrscott

@bryanrscott Thanks for keeping this nice package up to date!

npostman avatar Mar 02 '22 19:03 npostman

Curious if this project has stalled or if it's possible to install in Laravel 8, or even better, Laravel 9?

eugenefvdm avatar Nov 03 '22 12:11 eugenefvdm

@ eugenevdm the forked version supports Laravel 9

bryanrscott avatar Nov 03 '22 20:11 bryanrscott

@ eugenevdm the forked version supports Laravel 9

bryanrscott avatar Nov 03 '22 20:11 bryanrscott