sneaker icon indicating copy to clipboard operation
sneaker copied to clipboard

added support for configurable queue options

Open LKnulp opened this issue 6 years ago • 1 comments

I used the PR #32 as template. Splitted mailables into 3 classes for inhertiance and to difer between ShouldQueue-interface and none. Added three values to config to determine all necessary values.

LKnulp avatar Jul 12 '19 07:07 LKnulp

@LKnulp Creating an empty class for this purpose looks overkill to me. Please once go through the docs on how to send mails using mailable contracts.

My approach would be to remove the ShouldQueue from ExceptionMailer class. And then check from config if we need to send the mail using a queue or not instead of hardcoding it.

akaamitgupta avatar Jul 12 '19 09:07 akaamitgupta