workflow icon indicating copy to clipboard operation
workflow copied to clipboard

Proposal: Introduce `WorkflowUICommon`

Open dhavalshreyas opened this issue 5 years ago • 3 comments

A few container Screen that are currently in Samples, would be better situated with an independent dependency. This will enable easy consumption of these common UI containers.

Containers in Samples currently:

  • AlertContainer
  • BackStackContainer
  • ModalContainer

Possible future additions:

  • TabBarScreen #1098
  • EquatableScreen - A Screen that updates it's rendering only if it's contents have changed.
  • ViewControllerLifecycleObserverScreen - A Screen that has callbacks for some common UIViewController lifecycle events.

Proposal

Move container Screens from Samples to WorkflowUICommon and add WorkflowUICommon.podspec in root. Publish WorkflowUICommon.podspec to Cocoapods.

dhavalshreyas avatar May 18 '20 22:05 dhavalshreyas

IIRC, they're in Samples currently because we explicitly don't want them to be added as dependencies elsewhere — they're just guideposts to help others build their own containers. Outside of that, are we willing to take on the maintenance burden of these, given we use parallel implementations internally?

AquaGeek avatar May 26 '20 19:05 AquaGeek

One of the suggestions @bencochran brought up internally was the option of us publishing the structs for these Screens (instead of both the struct and the UIViewController) and allowing folks to add the conformance to Screen themselves (BYO view controller). That would at least let us close the gaps between these samples and our own internal versions.

AquaGeek avatar Jun 11 '20 22:06 AquaGeek

I believe this is the approach we're currently using in kotlin.

zach-klippenstein avatar Jun 11 '20 23:06 zach-klippenstein