okhttp icon indicating copy to clipboard operation
okhttp copied to clipboard

Avoid failing on shutdown executor

Open yschimke opened this issue 3 years ago • 1 comments

Testing of https://github.com/square/okhttp/issues/7410

Consider this fix for discussion. Open to suggestions.

Issue happens because RealCall.executeOn has rejected execute call and falls back to recursive handling.

yschimke avatar Aug 06 '22 12:08 yschimke

Pretty sure this is not the right fix, since Executor could be shutdown at any point. So will need to change AsyncCall.executeOn.

yschimke avatar Aug 08 '22 09:08 yschimke

Since promoteAndExecute is in the recursive path, this should work. But still open for suggestions here.

yschimke avatar Aug 15 '22 16:08 yschimke

@swankjesse happy to revisit after your review. In the mean time, give it some time to bake. Should only have any effect, after Executor is shutdown, so not likely to cause problems in normal use.

yschimke avatar Aug 15 '22 18:08 yschimke