logcat icon indicating copy to clipboard operation
logcat copied to clipboard
verified publisher icon square

Initial KMP Restructure

Open frenziedherring opened this issue 3 years ago • 3 comments

  • Updated src into source sets for common/jvm/js/android/native
  • Moved JVM code to JVM source set
  • Extracted platform dependent pieces into expect/actual
  • Implemented required 'actual's for JS & Native
  • Moved AndroidLogcatLogger to android source set

frenziedherring avatar May 15 '22 01:05 frenziedherring

Thanks a lot, this is really cool!

pyricau avatar May 18 '22 19:05 pyricau

@pyricau - I updated my branch based on the comments above. The biggest change was updating the test structure to prevent duplicating tests in N platforms. The common tests now leverage expect/actual to get an instance of the test logger for the platform, leaving the rest of the test intact. Let me know what you think about that. Thanks for the review!

frenziedherring avatar May 23 '22 02:05 frenziedherring

@pyricau - I downgraded some dependencies (and fixed tests that were failing) that should address Gradle failures in https://github.com/square/logcat/runs/6610273912?check_suite_focus=true. I downgraded the coroutines dependency to 1.5.2 which allowed going back to Kotlin 1.5.30 and Java 8. It's also only needed in commonTest.

frenziedherring avatar Jun 15 '22 01:06 frenziedherring