Blueprint icon indicating copy to clipboard operation
Blueprint copied to clipboard

AttributedLabel Link Accessibility

Open RoyalPineapple opened this issue 2 years ago • 3 comments

Updating attributed label's links to more closely mirror the SwiftUI accessibility experience

https://github.com/square/Blueprint/assets/219578/7255cbc0-2c6a-41a5-a0bc-9cd5ec5774c4

This is our current implementation, which doesn't announce links properly.

https://github.com/square/Blueprint/assets/219578/11c3e109-c632-4542-9e5b-11eddf618eba

Here is the new version, announcing links as they are read.

https://github.com/square/Blueprint/assets/219578/38aad435-825b-42f4-b65f-a70b5757691a

RoyalPineapple avatar May 30 '23 21:05 RoyalPineapple

It looks like there's some failing tests:

Failing tests:

	AttributedLabelTests.test_linkAttribute()
	AttributedLabelTests.test_textContainerRects()

kyleve avatar Nov 29 '23 13:11 kyleve

~~Replaced with https://github.com/square/Blueprint/pull/473~~

RoyalPineapple avatar Dec 05 '23 17:12 RoyalPineapple

@RoyalPineapple Moving to draft because I think this was addressed elsewhere but feel free to reopen if needed!

robmaceachern avatar Mar 14 '24 18:03 robmaceachern