sqls icon indicating copy to clipboard operation
sqls copied to clipboard

Add Clickhouse support

Open r-zenine opened this issue 4 years ago • 5 comments

Hello,

First of all , thanks for the project, it looks great !

I would like to know if you would welcome clickhouse support in sqls. I could look at the code and see how I could make that happen. In addition, given that clickhouse is open source, we could integrate CI tests in your current workflow.

Would you welcome such PR ? If so, could you point me to the right direction ?

I was planing to use the official go driver for clickhouse

Thanks Again, great work already ! Thank you for taking the time to build this LSP server.

r-zenine avatar Mar 21 '21 08:03 r-zenine

I added oracle support PR, recently. I think it is the minimal change of adding a new driver. Please talk a look

PhilipMok-cc avatar Dec 31 '21 02:12 PhilipMok-cc

Hello @PhilipMok-cc , Thank you for your answer !

Are you referring to this PR https://github.com/lighttiger2505/sqls/pull/78 ? I'll take a look next week-end to add the support of click house.

r-zenine avatar Jan 05 '22 18:01 r-zenine

Yes, but there are some issue.

  1. Testing required a service container to support. Other than that the test routine is covered all the issue I have met during testing and I think it is generic to all kind of DB.

PhilipMok-cc avatar Jan 05 '22 19:01 PhilipMok-cc

Hello!

Just mind that v2 version is on the road https://github.com/ClickHouse/clickhouse-go/releases/tag/v2.0.0-beta.5

Maintainers have already switched their production servers to v2.

franchb avatar Jan 26 '22 06:01 franchb

Hey :)

I've created a PR to add clickhouse database support. I hope this is still wanted!

(see #133)

patrickpichler avatar Feb 02 '24 06:02 patrickpichler