sqlflow icon indicating copy to clipboard operation
sqlflow copied to clipboard

[TODO]Support hints in goalisa

Open weiguoz opened this issue 5 years ago • 0 comments

In the issue: 2220, we plan to supports Maxcompute hints. goalisa is one of the dabase/sql driver of Maxcompute. We're going to support Maxcompute hints in goalisa at first. I found our parser is able to split the hints from a SQL program. What we want to do are:

  • To support passing the hints to the backend of the database, we need to implement interfaces DB.PrepareContext to prepare a stmt, then get the result via stmt.QueryContext(stmt.ExecContext). Moreover, we need to implement such methods in all database/sql drivers: goalisa/gomaxcompute/gohive to unify the code in SQLFlow.

    • [ ] gomaxcompute
    • [ ] gohive
    • [ ] goalisa
  • [ ] Extract the hints from the parse result, and the hints will be sent to the goalisa finally via runSingleSQLFlowStatement https://github.com/sql-machine-learning/sqlflow/blob/ddb63ce6a063d47aeb3dadcc2f5923f42b0a1ccb/pkg/sql/executor_ir.go#L105-L124

weiguoz avatar May 26 '20 12:05 weiguoz