springwolf-core icon indicating copy to clipboard operation
springwolf-core copied to clipboard

Units test to investigate AMQP generation

Open pdalfarr opened this issue 1 year ago • 1 comments

Units test to investigate AMQP generation I added some comments in the PR.

pdalfarr avatar Jun 05 '24 12:06 pdalfarr

Deploy Preview for springwolf-ui canceled.

Name Link
Latest commit 8c0950e89b30e232ea7b54f9832d347ebed20edd
Latest deploy log https://app.netlify.com/sites/springwolf-ui/deploys/666054a762d49700098046e9

netlify[bot] avatar Jun 05 '24 12:06 netlify[bot]

Hi @pdalfarr, I took this PR as a base to look into amqp and further understand how rabbitmq and the AsyncAPI amqp binding works. The result is https://github.com/springwolf/springwolf-core/pull/886

I agree with your point on the expected channel name. Assuming that is fixed, how to bind the routingKey + exchange with the queue (see my comment)?

Also, it would be great if you can verify the comments on RabbitListenerUtil as I gather them by testing, but have low confidence since I haven't used RabbitMQ in production (see https://github.com/springwolf/springwolf-core/pull/886/files#r1699142615 )

timonback avatar Jul 31 '24 21:07 timonback

Closing this PR, as the proposed changes have been merged via other PRs.

Also, part of the issue has been addressed, while the link from exchange to queue is missing in the AsyncAPI at this point. Lets move the discussion into the original Springwolf issue https://github.com/springwolf/springwolf-core/issues/366

timonback avatar Oct 19 '24 16:10 timonback