springwolf-core
springwolf-core copied to clipboard
Prepare to support Multi Format Schemas
Components Object now holds a map of <String, ComponentSchema> instead of <String, SchemaObject>.
ComponentSchema is a Container for either SchemaObject, SchemaReference or MultiFormatSchema.
This is a preparation to support other schema formats than asyncapi-schema, (for instance openapi-schema).
Deploy Preview for springwolf-ui ready!
| Name | Link |
|---|---|
| Latest commit | 6909eacac7925524a884beedd635910bb6f466fc |
| Latest deploy log | https://app.netlify.com/projects/springwolf-ui/deploys/68613f0fa5f86500087397f0 |
| Deploy Preview | https://deploy-preview-1325--springwolf-ui.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
Hi @tvahrst, we like the direction of the contribution.
We have two questions that might be best answered via a face-to-face call:
- Have you thought about using
ComponentSchemaeverywhere and thereby replacingSchemaObject? So that we do not need to check if it is a, then do ยง1, otherwise if it is b, then do ยง2. Eventhought the spec does allow for flexibility, we can restrict/simplify it for our needs. - So far we haven't written many comments. And would like to understand in which situation which comments would have helped.