arc.js icon indicating copy to clipboard operation
arc.js copied to clipboard
verified publisher icon springmeyer

Support for AMD and corrected browser

Open harryxue1999 opened this issue 7 years ago • 1 comments

  • Added load support for AMD (such as requirejs)
  • Added load support for CMD (as well as NodeJS)
  • Corrected browser implementation (script not loaded by script tag may not have arc defined in window)

harryxue1999 avatar Jul 18 '18 05:07 harryxue1999

hey @harryxue1999!

thank you for taking the time to propose this change and sorry for the belated response! turning arc.js into a UMD is still definitely an option but at this point it has also become pretty common for library authors to publish a bare ES module and let the consumer handle transpilation.

i'll need to chew on this a bit but i'm interested in more feedback if you (or anyone else) has opinions on the topic.

(maybe something like this? https://github.com/felixge/node-dateformat/pull/183)

jgravois avatar May 09 '22 20:05 jgravois