react-accessible-modal

react-accessible-modal copied to clipboard

I see this error on IE 11: ``` SCRIPT1046: Multiple definitions of a property not allowed in strict mode ``` and it points to this [line](https://github.com/springload/react-accessible-modal/blob/1464c9b7d6afad8585a645a0058e3f0a3a1a38a3/lib/index.js#L258) And this is what...

janzenz

In today's complex layouts, the behaviour of other components might indirectly affect our component render. ### [demo vid](https://d26dzxoao6i3hh.cloudfront.net/items/2E3r2s2p260T0y2t133w/Screen%20Recording%202017-12-20%20at%2003.04%20PM.mov) It's good practice to render "out of document flow"/"dynamic positioned elements outside...

renatodeleao

Add basic styling to the NPM package

6

Currently when you install the package it doesn't come with any css, so this means the modal doesn't even work as a modal, because it actually uses css transitions to...

katie-day

Get unit test coverage above 50%

1

We are now at ±20%. This is tracked on Coveralls: https://coveralls.io/github/springload/react-accessible-modal. All that's left to do is to write more tests! Easy, right?

thibaudcolas

Review accessibility of the modal

1

Specific things I'm not sure of or I think are wrong: - Why does it `stopPropagation` on click on the wrapper around the content? - Is it really a good...

thibaudcolas