react-accessible-accordion icon indicating copy to clipboard operation
react-accessible-accordion copied to clipboard

Semantic HTML improvements

Open sarah-j-lancaster opened this issue 4 years ago • 1 comments

Keen to merge into the React 18 branch so the changes can go out in a major together? Open to maybe also changing the prop name because now it seems a bit weird?

  • Replace divs with roles heading and button with the semantic HMTL.
  • Updated unit and integration tests
  • Updated the demo styles to remove those added by the native elements

sarah-j-lancaster avatar Dec 16 '21 21:12 sarah-j-lancaster

Coverage Status

Coverage decreased (-0.1%) to 87.786% when pulling 9e12c09a0fa564f956c22da2783c9a37a5fa956a on semantic-buttons into 47b5d894fdcc1743c5731ef635683d79f70ee259 on feature/react-18-useid.

coveralls avatar Dec 19 '21 21:12 coveralls