spring-data-rest icon indicating copy to clipboard operation
spring-data-rest copied to clipboard

Issue when updating a @OneToMany collection resource with a nested @ManyToOne/@OneToOne resource - PUT/PATCH

Open essl-noratt opened this issue 1 year ago • 1 comments

Spring Boot version: 3.3.2

After upgrading to Spring Boot 3, we have noticed an issue when trying to update a collection resource via the PUT and PATCH endpoints provided by Spring Data REST on a @RepositoryRestResource. When trying to update a @OneToMany collection element that has a nested @ManyToOne/@OneToOne resource, the nested resource is not being persisted correctly back to the database.

  • Adding new elements to the @OneToMany collection works fine with POST, PUT and PATCH. Nested resources are mapped correctly.
  • Updating the nested resource of an existing element in the @OneToMany collection does not update the nested resource.
  • Removing an element from the @OneToMany resource where the element isn't the last in the collection, causes all the elements after to shift up an index (which is correct) but doesn't accordingly carry their nested resource up with them, resulting in all the elements after the one being removed to have the wrong nested resources.

Please have a look at this example project which shows the setup that we have, along with a test class that will help demonstrate the issue.

essl-noratt avatar Jan 27 '25 17:01 essl-noratt

Hi @essl-noratt, I would like to work on this issue.

zali279 avatar Feb 27 '25 20:02 zali279