spring-data-rest icon indicating copy to clipboard operation
spring-data-rest copied to clipboard

Specifying null handling for 'sort' query params [DATAREST-1098]

Open spring-projects-issues opened this issue 8 years ago • 4 comments

Casey Link opened DATAREST-1098 and commented

It should be possible (or would be very nice!) to be able to specify the null handling when sorting a response with spring-data-rest.

This is quite important for our use cases, as we have some tables where nulls should be sorted last or first, depending on the specific field.

I see two possibilities here:

  1. the sort query param accepts an additional positional argument like ?sort=name,desc,nullslast
  2. QuerydslBinderCustomizer and QuerydslBindings are extended such that the sort details can be customized on the repository.
{
    default void customize(QuerydslBindings bindings, QPerson person)
    {
        bindings.bind(person.name).sort().nullsLast();
    }

Affects: 2.6.4 (Ingalls SR4)

1 votes, 3 watchers

spring-projects-issues avatar Jun 20 '17 11:06 spring-projects-issues

Oliver Drotbohm commented

I like your phrasing of "it should be possible". It indeed should. Unfortunately with JPA, it isn't. See the link to the JPA Github above

spring-projects-issues avatar Jun 20 '17 12:06 spring-projects-issues

member sound commented

Could you please add this as a feature? Using spring-data-rest is so nice, but lacking the possibility on how to sort nulls is crucial!

spring-projects-issues avatar Sep 10 '19 14:09 spring-projects-issues

It would still be great investigating into this issue.

membersound avatar Oct 20 '21 08:10 membersound

We did. And unfortunately nothing has changed in the mean time:

I like your phrasing of "it should be possible". It indeed should. Unfortunately with JPA, it isn't. See the link to the JPA Github above.

The upstream ticket for reference:

  • eclipse-ee4j/jpa-api#76

odrotbohm avatar Oct 20 '21 08:10 odrotbohm