spring-cli icon indicating copy to clipboard operation
spring-cli copied to clipboard

Fix for ProjectMerger.mergeMavenPlugins Xml Declarations Issue

Open jacobdanner opened this issue 11 months ago • 0 comments

Proposed Fix for ProjectMerger.mergeMavenPlugins Issue see: https://github.com/spring-projects/spring-cli/issues/217

Discovered while working on a project that was trying to merge some openapi plugin tooling. The ConversionUtil code was returning strings with xml declarations and that was breaking and not working as expectd in the openrewrite recipes that modify the pom's plugins

  • Added a Test for ConversionUtil to demonstrate existing behavior
  • Added Test for expected ConversionUtil output
  • Updated ConversionUtil to avoid returning dependencies with default dependency content
  • Updated MavenModificationTests with additional validation around merged/added plugins

jacobdanner avatar Feb 13 '25 16:02 jacobdanner