spring-boot SpringProfile arbiter fails without a Spring's environment

A issue has been raised and fixed in apache/logging-log4j2: https://github.com/apache/logging-log4j2/issues/1783

A detailed explanation of the proposed change may be found in this issue.

Basically, the null check for the environment is not necessary in the builder as the isCondition() method already correctly checks for a null environment.

Feb 05 '24 13:02 timgrohmann

@timgrohmann Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Feb 05 '24 13:02 pivotal-cla

@timgrohmann Thank you for signing the Contributor License Agreement!

Feb 05 '24 13:02 pivotal-cla

@philwebb As Log4j seems to have it's own SpringProfileArbiter which looks like ours, could we use that?

Feb 06 '24 13:02 mhalbritter

I don't think we can do that as it would introduce an (even stronger) cyclic dependency between the two projects.

Feb 09 '24 11:02 wilkinsona

Can we still integrate the upstream change into this project to fix the problem for Spring Boot users?

Feb 17 '24 10:02 timgrohmann

Yeah, I'll flag it to talk about it in our team meeting.

Feb 19 '24 08:02 mhalbritter

Thank you very much and congratulations on your first contribution :tada:!

Feb 28 '24 12:02 mhalbritter