spring-authorization-server icon indicating copy to clipboard operation
spring-authorization-server copied to clipboard

Return registration_endpoint in OidcProviderConfigurationEndpointFilter

Open bibibiu2017 opened this issue 4 years ago • 7 comments

Describe the bug OpenId configuration metadata endpoint does not return registration endpoint even though dynamic client registration it was implemented in gh-189

To Reproduce http://auth-server/.well-known/openid-configuration returns

{
    "issuer": "http://localhost:8000/authorization",
    "authorization_endpoint": "http://localhost:8000/authorization/oauth2/authorize",
    "token_endpoint": "http://localhost:8000/authorization/oauth2/token",
    "token_endpoint_auth_methods_supported": [
        "client_secret_basic",
        "client_secret_post"
    ],
    "jwks_uri": "http://localhost:8000/authorization/oauth2/jwks",
    "response_types_supported": [
        "code"
    ],
    "grant_types_supported": [
        "authorization_code",
        "client_credentials",
        "refresh_token"
    ],
    "subject_types_supported": [
        "public"
    ],
    "id_token_signing_alg_values_supported": [
        "RS256"
    ],
    "scopes_supported": [
        "openid"
    ]
}

Expected behavior Should contain the client registration endpoint

bibibiu2017 avatar Jul 24 '21 10:07 bibibiu2017

hi @jgrandja. Can I work on this issue?

sahariardev avatar Apr 09 '22 04:04 sahariardev

Thanks for your interest @sahariardev.

We're holding off on adding new features and enhancements until after we release 0.3.0.

Our top priority for 0.3.0 is to deliver the initial version of the reference documentation. We still have a lot of work to do so we need to keep focused.

Please reach out again after 0.3.0 is released May 23.

jgrandja avatar Apr 15 '22 08:04 jgrandja

Thanks for the reply. I will reach out after 0.3.0 release.

sahariardev avatar Apr 16 '22 12:04 sahariardev

hi @jgrandja, Can I work on this issue?

sahariardev avatar May 27 '22 02:05 sahariardev

@sahariardev Yes, the issue is yours.

Please keep in mind that OidcProviderConfigurationEndpointFilter should return the registration_endpoint ONLY if the OpenID Connect 1.0 Client Registration Endpoint is enabled - it's disabled by default.

jgrandja avatar May 30 '22 18:05 jgrandja

Thanks for the reply. I will keep that in mind

sahariardev avatar May 31 '22 17:05 sahariardev

Hi @jgrandja, I have created a Draft PR for this issue. Please review and let me know your feedbacks. Here is the PR link https://github.com/spring-projects/spring-authorization-server/pull/762

sahariardev avatar Jun 03 '22 05:06 sahariardev