spring-ai icon indicating copy to clipboard operation
spring-ai copied to clipboard

feat FunctionCallingOptions

Open youngmoneee opened this issue 1 year ago • 1 comments

This change enhances safety in multi-threaded environments by returning unmodifiable objects from getters.

  • getter returns unmodifiable Collection

Fixes #407

youngmoneee avatar Mar 10 '24 08:03 youngmoneee

@young Can you link this PR to that issue to make sure the issue is automatically closed once this PR is merged?

To do so, just change the last line of this PR's description to this:

Fixes https://github.com/spring-projects/spring-ai/issues/407

codespearhead avatar Jul 17 '24 13:07 codespearhead

Hi. Thanks, I know it has taken a while to review this. The code has changed a bit, so I'll open a up a new PR to address the immutability concerns and add you an an author in the PR commit message @youngmoneee

markpollack avatar Oct 22 '24 20:10 markpollack

This has been address in #1584

markpollack avatar Oct 23 '24 22:10 markpollack